feat: add more debug signals (#1743)

* feat: add more debug signals * fix * fix * message from error
PostHog · Feb 17, 2025 · 8a90147 · 8a90147
1 parent 72796b0
commit 8a90147
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 2 deletions.
diff --git a/src/__tests__/posthog-core.ts b/src/__tests__/posthog-core.ts
@@ -444,6 +444,9 @@ describe('posthog core', () => {
                 $is_identified: false,
                 $process_person_profile: false,
                 $recording_status: 'buffering',
+                $sdk_debug_replay_internal_buffer_length: 0,
+                $sdk_debug_replay_internal_buffer_size: 0,
+                $sdk_debug_retry_queue_size: 0,
             })
         })
 
@@ -467,6 +470,9 @@ describe('posthog core', () => {
                 $is_identified: false,
                 $process_person_profile: false,
                 $recording_status: 'buffering',
+                $sdk_debug_replay_internal_buffer_length: 0,
+                $sdk_debug_replay_internal_buffer_size: 0,
+                $sdk_debug_retry_queue_size: 0,
             })
         })
 
@@ -599,6 +605,40 @@ describe('posthog core', () => {
             expect(pageleaveProperties.$pageview_id).toEqual('pageview-id-2')
             expect(pageleaveProperties.$prev_pageview_id).toEqual('pageview-id-2')
         })
+
+        it('includes pageview id from previous pageview', () => {
+            const pageview1Properties = posthog._calculate_event_properties(
+                '$pageview',
+                {},
+                new Date(),
+                'pageview-id-1'
+            )
+            expect(pageview1Properties.$pageview_id).toEqual('pageview-id-1')
+
+            const event1Properties = posthog._calculate_event_properties('custom event', {}, new Date(), 'event-id-1')
+            expect(event1Properties.$pageview_id).toEqual('pageview-id-1')
+
+            const pageview2Properties = posthog._calculate_event_properties(
+                '$pageview',
+                {},
+                new Date(),
+                'pageview-id-2'
+            )
+            expect(pageview2Properties.$pageview_id).toEqual('pageview-id-2')
+            expect(pageview2Properties.$prev_pageview_id).toEqual('pageview-id-1')
+
+            const event2Properties = posthog._calculate_event_properties('custom event', {}, new Date(), 'event-id-2')
+            expect(event2Properties.$pageview_id).toEqual('pageview-id-2')
+
+            const pageleaveProperties = posthog._calculate_event_properties(
+                '$pageleave',
+                {},
+                new Date(),
+                'pageleave-id'
+            )
+            expect(pageleaveProperties.$pageview_id).toEqual('pageview-id-2')
+            expect(pageleaveProperties.$prev_pageview_id).toEqual('pageview-id-2')
+        })
     })
 
     describe('_handle_unload()', () => {

diff --git a/src/posthog-core.ts b/src/posthog-core.ts
@@ -990,8 +990,15 @@ export class PostHog {
             properties['$window_id'] = windowId
         }
 
-        if (this.sessionRecording) {
-            properties['$recording_status'] = this.sessionRecording.status
+        try {
+            if (this.sessionRecording) {
+                properties['$recording_status'] = this.sessionRecording.status
+                properties['$sdk_debug_replay_internal_buffer_length'] = this.sessionRecording['buffer'].data.length
+                properties['$sdk_debug_replay_internal_buffer_size'] = this.sessionRecording['buffer'].size
+            }
+            properties['$sdk_debug_retry_queue_size'] = this._retryQueue?.['queue']?.length
+        } catch (e: any) {
+            properties['$sdk_debug_error_capturing_properties'] = String(e)
         }
 
         if (this.requestRouter.region === RequestRouterRegion.CUSTOM) {