Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing types #1703

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rafaeelaudibert
Copy link
Member

These were incorrectly removed in 58550b9

I could say it was Cursor fault, but I should've paid more attention

Closes #1702

These were incorrectly removed in 58550b9

I could say it was Cursor fault, but I should've paid more attention
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 29, 2025 8:27pm

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rafaeelaudibert rafaeelaudibert added the bump patch Bump patch version when this PR gets merged label Jan 29, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Restores three critical TypeScript types in the SessionRecordingOptions interface that were accidentally removed, enabling proper type checking for input masking configurations in session recordings.

  • Added back maskAllInputs type to control global input masking behavior
  • Restored maskInputOptions type for configuring specific input masking settings
  • Re-added maskInputFn type for custom input masking functions
  • Types are derived from rrweb.record options and align with current documentation
  • Fixes type errors reported in issue Possible unintended SessionRecordingOptions type change #1702 while maintaining backward compatibility

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

Size Change: 0 B

Total Size: 3.28 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 215 kB
dist/array.full.es5.js 266 kB
dist/array.full.js 369 kB
dist/array.full.no-external.js 368 kB
dist/array.js 181 kB
dist/array.no-external.js 180 kB
dist/customizations.full.js 13.8 kB
dist/dead-clicks-autocapture.js 14.5 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/main.js 182 kB
dist/module.full.js 369 kB
dist/module.full.no-external.js 368 kB
dist/module.js 181 kB
dist/module.no-external.js 180 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 68.8 kB
dist/surveys.js 71.8 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@rafaeelaudibert rafaeelaudibert merged commit e6eaa90 into main Jan 29, 2025
31 of 32 checks passed
@rafaeelaudibert rafaeelaudibert deleted the posthog-js-1702-fix-removed-typescript-types branch January 29, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible unintended SessionRecordingOptions type change
2 participants