-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flags): Revert "feat(flags): Enjoy the benefits of /decide?v=4
. $feature_flag_called
events contain more details such as flag version"
#1842
Conversation
This reverts commit 4c25512.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/decide?v=4
. $feature_flag_called
events contain more details such as flag version"/decide?v=4
. $feature_flag_called
events contain more details such as flag version"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR reverts the /decide
endpoint from v4 back to v3 due to issues with how v4 handled disabled feature flags.
- Changed
/decide/?v=4
back to/decide/?v=3
insrc/posthog-featureflags.ts
and related test files - Removed
core-js/features/object/from-entries
polyfill fromsrc/entrypoints/array.full.es5.ts
as it's no longer needed - Updated test assertions across multiple files to expect v3 endpoint URLs instead of v4
- Maintains backwards compatibility while fixing feature flag handling for disabled flags
- Test coverage remains comprehensive across different domains and scenarios
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a bump patch label?
oh yeah, wrong label |
Size Change: -22.6 kB (-0.62%) Total Size: 3.6 MB
ℹ️ View Unchanged
|
Reverts #1838
Oof, v4 responses from
/decide
were not smart about flags that were just straight disabled, let's roll back to v3