-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flags): Enjoy the benefits of /decide?v=4
#1843
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/decide?v=4
(#1838)" (#…/decide?v=4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR re-enables support for /decide?v=4
endpoint across the PostHog JavaScript SDK, updating test files and adding IE11 compatibility.
- Added Object.fromEntries polyfill in
src/entrypoints/array.full.es5.ts
for IE11 support - Updated test assertions in
src/__tests__/posthog-core.loaded.test.ts
to expect/decide/?v=4
endpoint - Modified
src/posthog-featureflags.ts
to handle both legacy and v4 API formats - Updated URL patterns in
playwright/session-recording/session-recording-network-recorder.spec.ts
for v4 endpoint testing - Ensured backward compatibility while enabling access to newer feature flag functionality
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's hoping we don't have to revert this again lmao.
Thanks for doing this :)
Size Change: +22.6 kB (+0.63%) Total Size: 3.63 MB
ℹ️ View Unchanged
|
This reverts commit 502c4c0 which reverted 4c25512. We got ourselves a revert chain!
The purpose of this commit is to re-enable support for
/decide?v=4
. See this PR for more details: #1838