Deprecate the context argument #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used anywhere, a vestigial remnant of a time long ago.
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR deprecates and removes the unused 'context' parameter across the PostHog Python SDK, focusing on cleaning up legacy code.
- Added deprecation warnings using
warnings.warn()withDeprecationWarningin all relevant methods inposthog/__init__.py - Removed context parameter from command line arguments and function calls in
simulator.py - Updated test cases in
test_client.pyto use named parameters and removed context-related assertions - Maintained backward compatibility while signaling future removal of the parameter across all affected files
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
70
to
74
| def set_once(): | ||
| posthog.set_once( | ||
| options.distinct_id, | ||
| properties=json_hash(options.traits), | ||
| context=json_hash(options.context), | ||
| ) |
There was a problem hiding this comment.
style: set_once is using traits for properties parameter which may be confusing - consider renaming the command line arg to match the function signature
Comment on lines
77
to
81
| def set(): | ||
| posthog.set( | ||
| options.distinct_id, | ||
| properties=json_hash(options.traits), | ||
| context=json_hash(options.context), | ||
| ) |
There was a problem hiding this comment.
style: set is using traits for properties parameter which may be confusing - consider renaming the command line arg to match the function signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used anywhere, a vestigial remnant of a time long ago.
This PR supercedes #54.