Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinctId and anonymousId should degrade gracefully if they are strings that can't be parsed #24

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 24, 2025

Follow up PostHog/posthog-js-lite#406

Degrade gracefully if dist and anon id are not parseable.
Degrade gracefully if anything happens instead of hard crash - but add logging so we know whats going on

@marandaneto marandaneto changed the title fix/parse dist anon fix: distinctId and anonymousId should degrade gracefully if they are strings that can't be parsed Feb 24, 2025
@marandaneto marandaneto requested review from a team and ioannisj February 24, 2025 09:19
Copy link
Contributor

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions but LG

@marandaneto marandaneto merged commit e21373a into main Feb 24, 2025
7 checks passed
@marandaneto marandaneto deleted the fix/parse-dist-anon branch February 24, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants