fix(flags): Add appropriate timeouts, fix some other misc things #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
feature_flag_request_timeout_seconds
configuration option, defaulting to 3s to control flag timeouts/decide
endpoint directly, but viaget_all_flags_and_payloads
which in turn does all necessary error handling. Before this, getting payloads would always throw :/beta-feature2
reflect that, since previously this would go to decide, but now it wouldn't, which is infact the ideal thing to do. (and thus to test the old flow we need an extra flag that is present but can't be locally evaluated).Noticed while doing this that the above problem exist in posthog-python as well, will update that too