Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for color themes and result color assignment #10539

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add docs for color themes and result color assignment #10539

wants to merge 4 commits into from
+79 −0

Conversation

thmsobrmlr
Copy link
Contributor

Changes

Adds docs for color themes and result color assignment.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Jan 30, 2025 10:08pm

daniloc
daniloc requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@daniloc daniloc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things:

  • Use Cloudinary to host the images (they're currently pointed at localhost in any case)
  • Do a quick pass and use bolds instead of quotes for UI elements you want to draw the user through/to

Otherwise good stuff!

contents/docs/product-analytics/color-themes.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/color-themes.mdx Outdated Show resolved Hide resolved
daniloc
daniloc approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@daniloc daniloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@thmsobrmlr thmsobrmlr mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloc daniloc daniloc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @daniloc