Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Surveys): Enable partial survey responses #26842

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Phanatic
Copy link
Contributor

Problem

Needs : PostHog/posthog-js#1597

This PR enables the server to process send partial survey responses as users fill out the survey, not at the end once all questions are answered : #19300

Changes

  1. Show completed/dismissed count in status bar for surveys
image
  1. Show completed responses, if available in the data table, otherwise show partial responses.
image

TODO

  • Fix data table display of the partial survey responses to include Person profiles.
  • Fix NPS and other calculations since they don't account for partial/completed survey responses.
  • [ ]

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

  • Add tests for this new behavior.

@@ -0,0 +1,178 @@
import { actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file make sense in this PR? its error tracking related

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@marandaneto marandaneto reopened this Jan 7, 2025
@marandaneto marandaneto added waiting Prevents stale-bot from marking the PR as stale. and removed stale labels Jan 7, 2025
@hivokas
Copy link

hivokas commented Feb 19, 2025

It would be awesome to have it released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Prevents stale-bot from marking the PR as stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants