Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taxonomy): additional properties for ios sdk and mac catalyst #28019

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ioannisj
Copy link
Contributor

Problem

relates to: PostHog/posthog-ios#287

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added two new iOS SDK properties to the taxonomy system to identify iOS apps running on macOS platforms, specifically tracking Mac Catalyst apps and iOS apps running on Apple Silicon Macs.

  • Added $is_mac_catalyst_app property to identify Mac Catalyst apps running on macOS
  • Added $is_ios_running_on_mac property to identify iOS apps running on Apple Silicon Macs
  • Properties follow existing taxonomy structure in /frontend/src/lib/taxonomy.tsx
  • Properties are boolean flags with examples of 'true'/'false' values

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@ioannisj ioannisj requested a review from marandaneto January 29, 2025 11:01
Copy link
Contributor

Size Change: +1.09 kB (+0.09%)

Total Size: 1.16 MB

Filename Size Change
frontend/dist/toolbar.js 1.16 MB +1.09 kB (+0.09%)

compressed-size-action

@ioannisj ioannisj merged commit 97e0ad7 into master Feb 4, 2025
100 checks passed
@ioannisj ioannisj deleted the feat/add-mac-catalyst-property-to-taxonomy branch February 4, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants