chore: add device type filtering on surveys #28109
Conversation
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Here's my summary of the key changes in this PR:
Adds device type filtering capability to PostHog surveys, allowing targeting based on device types (Mobile, Tablet, Desktop).
- Renamed
SurveyUrlMatchTypetoSurveyMatchTypeintypes.tsto support both URL and device type matching conditions - Added new fields
deviceTypesanddeviceTypesMatchTypeto Survey interface conditions object - Implemented device type display condition UI in
SurveyDisplaySummarycomponent with matching type selector - Added
inputClassNameprop toPropertyValuecomponent to support device type filtering styles - Updated survey logic to handle validation and processing of device type matching conditions
The changes enable more granular survey targeting while maintaining backward compatibility with existing URL-based targeting.
7 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
|
@lucasheriques are you planning to add tests? |
|
@marandaneto the logic tests don't really cover any display conditions tests for now - they only cover branching and different survey types (open vs multiple question etc). so no plan to add new tests for this case now on my end |
| export function getPropertyKey(value: string, type: TaxonomicFilterGroupType): string { | ||
| // Find the key by looking through the mapping | ||
| const group = CORE_FILTER_DEFINITIONS_BY_GROUP[type] | ||
| if (group) { | ||
| const foundKey = Object.entries(group).find(([_, def]) => (def as any).label === value || _ === value)?.[0] | ||
| return foundKey || value | ||
| } | ||
| return value | ||
| } |
There was a problem hiding this comment.
@pauldambra do you know any other way to use the labels/keys from taxonomy instead of duplicating everywhere? I feel like this should be done in a lot of places already so I wonder if this method is necessary.
Not a blocker since it is approved and it works :)
There was a problem hiding this comment.
keys are different than labels here. Key I'm treating as the $device_type, and label would be Device Type.
I didn't find a way in the codebase where this existed already, which is why I created this function 🤔 but if @pauldambra i'd be happy to fix it!
Problem
PR for SDK logic: PostHog/posthog-js#1698
Closes #24495
Changes
adds this a new display condition for Surveys: Device Types
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested on local posthog instance if a Survey set to display on specific device types was only shown on those devices.