chore: upgrade to Python 3.12.11 #38083

webjunkie · 2025-09-15T09:33:39Z

Problem

We are on Python 3.11 still

Changes

Upgrades Python interpreter from 3.11 to 3.12.11 and updates configuration to explicitly pin the patch version (==3.12.11).

Reasoning:

Ensures all CI jobs and developers using e.g. flox run against the same interpreter build, avoiding subtle ABI differences and dependency resolution mismatches across patch releases.
Aligns with our approach of pinning application dependencies — the Python runtime should be just as reproducible.

How did you test this code?

Relying on tests
Checked compatibility with various packages

github-actions · 2025-09-17T11:29:48Z

Size Change: 0 B

Total Size: 3.05 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	3.05 MB

_{compressed-size-action}

webjunkie · 2025-09-18T07:17:07Z

@pauldambra and @aspicer I guess you were involved in the last Python updated. Any particular area to pay special attention to?

pauldambra · 2025-09-18T08:47:59Z

i think that the django upgrades have been more painful than the python ones

my guess is saml / sso / openssl is the one to watch

i bet we're out of date on dependencies and type packages and that's where any changes will come from

god speed!

webjunkie · 2025-09-18T09:12:35Z

i bet we're out of date on dependencies and type packages and that's where any changes will come from

So far it's looking suspiciously good 🫠

greptile-apps

_{59 files reviewed, 2 comments}

_{Edit Code Review Bot Settings | Greptile}

github-actions · 2025-10-06T15:05:43Z

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

playwright/__snapshots__/pageview-trends-insight.png

What this means:

These screenshots are changing on each test run (timing issues, rendering differences, etc.)
This prevents reliable verification and blocks auto-merge
Human intervention is required

How to fix:

Investigate flakiness: Check test timing, wait for elements, stabilize animations
Fix the underlying issue: Don't just update snapshots repeatedly
Verify locally: Run tests multiple times to ensure stability
Push your fix: This will reset the flap counter

If you need to proceed anyway:

Fix the test flakiness first (recommended)
Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

…nd SQL modules Fixes E2E test failures where ClickHouse distributed tables reference wrong database name ('default' instead of 'posthog_test'). Root cause: Django settings imported at module level bind to values before test fixtures set environment variables. Changes: - table_engines.py: Remove default parameter binding in Distributed.__init__, evaluate cluster/database at call time - person/sql.py: Switch from posthog.settings to django.conf.settings, convert module-level SQL to functions - error_tracking/sql.py: Convert remaining module-level SQL strings to functions - Migrations and test files: Add () to call converted SQL functions Technical detail: django.conf.settings is a LazySettings proxy that defers attribute access until call time, preventing early binding.

…odule import Changed from `from posthog import settings` to `from django.conf import settings` to align with master's pattern and use Django's LazySettings proxy. Django's settings proxy defers ALL attribute lookups until access time, making it immune to import timing issues in both Python 3.11 and 3.12. This is the correct, battle-tested Django pattern that master already uses. Files updated: - posthog/models/app_metrics2/sql.py - posthog/models/person/sql.py - posthog/models/error_tracking/sql.py - posthog/clickhouse/table_engines.py - posthog/hogql/printer.py

github-actions · 2025-10-06T16:24:00Z

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

playwright/__snapshots__/pageview-trends-insight.png

What this means:

These screenshots are changing on each test run (timing issues, rendering differences, etc.)
This prevents reliable verification and blocks auto-merge
Human intervention is required

How to fix:

Investigate flakiness: Check test timing, wait for elements, stabilize animations
Fix the underlying issue: Don't just update snapshots repeatedly
Verify locally: Run tests multiple times to ensure stability
Push your fix: This will reset the flap counter

If you need to proceed anyway:

Fix the test flakiness first (recommended)
Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

posthog-bot · 2025-10-06T19:52:36Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 12)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

APP_METRICS_MV_TABLE_SQL was a lambda with an f-string that evaluated settings.CLICKHOUSE_DATABASE at module import time instead of call time. This caused tests to create tables in 'default' database instead of 'posthog_test'. Convert lambda to proper function so settings are evaluated at runtime.

# Conflicts: # frontend/__snapshots__/components-playerinspector-itemevent--group-identify-event--dark.png # frontend/__snapshots__/components-playerinspector-itemevent--group-identify-event--light.png

posthog-bot · 2025-10-07T14:31:56Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-10-07T14:39:26Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

# Conflicts: # posthog/async_migrations/examples/example.py # posthog/clickhouse/table_engines.py

# Conflicts: # .github/workflows/ci-backend-update-test-timing.yml # .github/workflows/ci-backend.yml # .github/workflows/ci-e2e-playwright.yml # .github/workflows/ci-python.yml # posthog/api/test/__snapshots__/test_api_docs.ambr # uv.lock

github-actions · 2025-10-13T05:42:32Z

Migration SQL Changes

Hey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:

`posthog/migrations/0463_datawarehousemodelpath_and_more.py`

BEGIN;
--
-- Raw SQL operation
--
CREATE EXTENSION IF NOT EXISTS ltree;
--
-- Create model DataWarehouseModelPath
--
CREATE TABLE "posthog_datawarehousemodelpath" ("created_at" timestamp with time zone NOT NULL, "updated_at" timestamp with time zone NULL, "id" uuid NOT NULL PRIMARY KEY, "path" ltree NOT NULL, "created_by_id" integer NULL, "saved_query_id" uuid NULL, "table_id" uuid NULL, "team_id" integer NOT NULL);
--
-- Create constraint unique_team_id_path on model datawarehousemodelpath
--
ALTER TABLE "posthog_datawarehousemodelpath" ADD CONSTRAINT "unique_team_id_path" UNIQUE ("team_id", "path") DEFERRABLE INITIALLY IMMEDIATE;
ALTER TABLE "posthog_datawarehousemodelpath" ADD CONSTRAINT "posthog_datawarehous_created_by_id_68be5ace_fk_posthog_u" FOREIGN KEY ("created_by_id") REFERENCES "posthog_user" ("id") DEFERRABLE INITIALLY DEFERRED;
ALTER TABLE "posthog_datawarehousemodelpath" ADD CONSTRAINT "posthog_datawarehous_saved_query_id_0ff43777_fk_posthog_d" FOREIGN KEY ("saved_query_id") REFERENCES "posthog_datawarehousesavedquery" ("id") DEFERRABLE INITIALLY DEFERRED;
ALTER TABLE "posthog_datawarehousemodelpath" ADD CONSTRAINT "posthog_datawarehous_table_id_f1314089_fk_posthog_d" FOREIGN KEY ("table_id") REFERENCES "posthog_datawarehousetable" ("id") DEFERRABLE INITIALLY DEFERRED;
ALTER TABLE "posthog_datawarehousemodelpath" ADD CONSTRAINT "posthog_datawarehous_team_id_30be3718_fk_posthog_t" FOREIGN KEY ("team_id") REFERENCES "posthog_team" ("id") DEFERRABLE INITIALLY DEFERRED;
CREATE INDEX "posthog_datawarehousemodelpath_created_by_id_68be5ace" ON "posthog_datawarehousemodelpath" ("created_by_id");
CREATE INDEX "posthog_datawarehousemodelpath_saved_query_id_0ff43777" ON "posthog_datawarehousemodelpath" ("saved_query_id");
CREATE INDEX "posthog_datawarehousemodelpath_table_id_f1314089" ON "posthog_datawarehousemodelpath" ("table_id");
CREATE INDEX "posthog_datawarehousemodelpath_team_id_30be3718" ON "posthog_datawarehousemodelpath" ("team_id");
CREATE INDEX "team_id_path" ON "posthog_datawarehousemodelpath" ("team_id", "path");
CREATE INDEX "team_id_saved_query_id" ON "posthog_datawarehousemodelpath" ("team_id", "saved_query_id");
CREATE INDEX "model_path_path" ON "posthog_datawarehousemodelpath" USING gist ("path");
COMMIT;

…sion Removes IF NOT EXISTS clause from ltree extension creation that was added during merge but turned out to be unnecessary. The migration runs normally without it.

Removes snapshot files that no longer exist in master, likely due to test changes or removal.

Updates Black and Dagster tool configurations to use Python 3.12: - Black target version py311 -> py312 - Dagster python_version 3.11 -> 3.12 Ensures tool configurations match the Python 3.12 upgrade.

This reverts commit 77e8ce5.

webjunkie and others added 7 commits September 16, 2025 08:58

Upgrade to Python 3.12.11

c85e1a7

Fix ruff

2b4f4dd

Adjust workflow

52edaaa

Upgrade kafka-python to 2.0.6

814aba4

Update query snapshots

81c3276

Fix assertDictContainsSubset removal

1711f9b

Fix isinstance issue

9d503bc

webjunkie force-pushed the chore/upgrade-to-python-3.12.11 branch from a5ae229 to 9d503bc Compare September 16, 2025 07:57

webjunkie added 5 commits September 16, 2025 10:28

Fix mypy

5c072dc

Fix more test errors

d40814b

Fix mypy

12bf2d5

Fix

7a19a87

Fix

93a5120

webjunkie added the deploy label Sep 16, 2025

webjunkie added 2 commits September 16, 2025 16:45

Try fix unit

ecf3fdc

Make sure we pin in uv

164b75b

webjunkie removed the deploy label Sep 17, 2025

webjunkie requested review from aspicer and pauldambra September 18, 2025 07:15

webjunkie self-assigned this Sep 18, 2025

webjunkie marked this pull request as ready for review September 18, 2025 10:08

posthog-bot requested review from a team September 18, 2025 10:10

posthog-project-board-bot bot added this to Feature Flags Sep 18, 2025

posthog-project-board-bot bot moved this to In Review in Feature Flags Sep 18, 2025

greptile-apps bot reviewed Sep 18, 2025

View reviewed changes

webjunkie and others added 4 commits October 6, 2025 17:22

Update E2E screenshots for Playwright

2043756

Update E2E screenshots for Playwright

5fb1549

webjunkie and others added 3 commits October 6, 2025 21:32

merge: resolve conflicts from fix/clickhouse-settings-early-binding

a39827b

Update E2E screenshots for Playwright

6ce3437

Update UI snapshots for chromium (12)

c6b8ec0

github-actions bot and others added 4 commits October 6, 2025 20:03

Update E2E screenshots for Playwright

01120e9

Merge branch 'master' into chore/upgrade-to-python-3.12.11

a83bb5c

# Conflicts: # frontend/__snapshots__/components-playerinspector-itemevent--group-identify-event--dark.png # frontend/__snapshots__/components-playerinspector-itemevent--group-identify-event--light.png

Update E2E screenshots for Playwright

9c23141

webjunkie mentioned this pull request Oct 7, 2025

fix(clickhouse): prevent early binding of settings in table engines and SQL #39183

Merged

Merge commit '3a673b937d' into chore/upgrade-to-python-3.12.11

b408a46

# Conflicts: # posthog/async_migrations/examples/example.py # posthog/clickhouse/table_engines.py

webjunkie force-pushed the chore/upgrade-to-python-3.12.11 branch from 757cabe to b408a46 Compare October 7, 2025 19:43

webjunkie added 3 commits October 13, 2025 07:52

revert(migrations): remove unnecessary IF NOT EXISTS from ltree exten…

9ad841c

…sion Removes IF NOT EXISTS clause from ltree extension creation that was added during merge but turned out to be unnecessary. The migration runs normally without it.

chore(snapshots): remove obsolete trendsline snapshots

417f7f7

Removes snapshot files that no longer exist in master, likely due to test changes or removal.

chore(python3.12): update tool configs to Python 3.12

86a8084

Updates Black and Dagster tool configurations to use Python 3.12: - Black target version py311 -> py312 - Dagster python_version 3.11 -> 3.12 Ensures tool configurations match the Python 3.12 upgrade.

webjunkie merged commit 77e8ce5 into master Oct 13, 2025
186 of 187 checks passed

github-project-automation bot moved this from In Review to Done in Feature Flags Oct 13, 2025

webjunkie deleted the chore/upgrade-to-python-3.12.11 branch October 13, 2025 06:32

webjunkie added a commit that referenced this pull request Oct 13, 2025

Revert "chore: upgrade to Python 3.12.11 (#38083)"

c456595

This reverts commit 77e8ce5.

webjunkie mentioned this pull request Oct 13, 2025

Revert "chore: upgrade to Python 3.12.11" #39533

Closed

adamleithp pushed a commit that referenced this pull request Oct 14, 2025

chore: upgrade to Python 3.12.11 (#38083)

26291e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: upgrade to Python 3.12.11 #38083

chore: upgrade to Python 3.12.11 #38083

Uh oh!

webjunkie commented Sep 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

webjunkie commented Sep 18, 2025

Uh oh!

pauldambra commented Sep 18, 2025

Uh oh!

webjunkie commented Sep 18, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

posthog-bot commented Oct 6, 2025

Uh oh!

posthog-bot commented Oct 7, 2025

Uh oh!

posthog-bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chore: upgrade to Python 3.12.11 #38083

chore: upgrade to Python 3.12.11 #38083

Uh oh!

Conversation

webjunkie commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

How did you test this code?

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webjunkie commented Sep 18, 2025

Uh oh!

pauldambra commented Sep 18, 2025

Uh oh!

webjunkie commented Sep 18, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 6, 2025

⚠️ Flapping Screenshots Detected

Uh oh!

github-actions bot commented Oct 6, 2025

⚠️ Flapping Screenshots Detected

Uh oh!

posthog-bot commented Oct 6, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Oct 7, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Oct 7, 2025

📸 UI snapshots have been updated

Uh oh!

github-actions bot commented Oct 13, 2025

Migration SQL Changes

posthog/migrations/0463_datawarehousemodelpath_and_more.py

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

webjunkie commented Sep 15, 2025 •

edited

Loading

github-actions bot commented Sep 17, 2025 •

edited

Loading

`posthog/migrations/0463_datawarehousemodelpath_and_more.py`