feat(max): enable parallel tool calls #38811
Conversation
posthog-bot
requested review from
a team,
ablaszkiewicz,
daibhin,
hpouillot and
oliverb123
|
Size Change: 0 B Total Size: 3.05 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…-search' into feat/paralel-tool-calls
…-search' into feat/paralel-tool-calls
ee/hogai/graph/taxonomy/nodes.py
Outdated
| # If we're still here, check if we've hit the iteration limit within this cycle | ||
| if state.iteration_count >= self.MAX_ITERATIONS: | ||
| return self._get_reset_state(ITERATION_LIMIT_PROMPT, "max_iterations", state) |
There was a problem hiding this comment.
Shouldn't it check for LLM turns, not for the number of tool calls? It doesn't make sense to limit by tool count.
There was a problem hiding this comment.
The state.iteration_count increases by one only when the llm returns, I think I am making a mistake here by checking for its value in every tool_call processing, we should only check once. Let me know if that makes sense.
| for action, _ in intermediate_steps: | ||
| try: | ||
| tool_input = self._toolkit.get_tool_input_model(action) | ||
| except ValidationError as e: |
There was a problem hiding this comment.
One might be broken, but others might not be. We should process all generated tools.
There was a problem hiding this comment.
True, fixed that
| tool_call_id=action.log, | ||
| ) | ||
| tool_result_msg.append(tool_msg) | ||
| tool_msgs.append(tool_msg) |
There was a problem hiding this comment.
Can we move tool_msgs closer to the loop? They're quite distant now.
|
|
||
| messages: Sequence[AssistantMessageUnion] = Field(default=[]) | ||
|
|
||
| iteration_count: int = Field(default=0) |
There was a problem hiding this comment.
There may be some quirks with LangGraph defaults. Are you sure that the Tools node doesn't reset the iteration count when it returns the partial state?
There was a problem hiding this comment.
True, the tool node resets the count, I had to pass the iteration_count when returning the partial state there
| if tool_metadata["lookup_feature_flag"]: | ||
| tool_input, tool_call_id = tool_metadata["lookup_feature_flag"][0] | ||
| result = self._lookup_feature_flag(tool_input.arguments.flag_key) # type: ignore | ||
| return {tool_call_id: result} |
There was a problem hiding this comment.
This line will only handle a single tool, but it might have multiple tools.
denakorita
force-pushed
the
feat/paralel-tool-calls
branch
from
8a3b67b to
144c1d4
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
…-search' into feat/paralel-tool-calls
denakorita
merged commit c96563d
into
feat/allow-multiple-entity-event-search
4 participants
Problem
Taxonomy search should be optimised to reduce the time spent exploring entities and properties when building HogQL