Skip to content

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Sep 30, 2025

Problem

This can take a while, especially when increasing the number of clusters, so I often multitask. This adds a command line flag to make a sound on mac when it's finished

Changes

Add a flag, to use the say command when finishing

How did you test this code?

Just local dev, it's a dev script so doesn't need a ton of testing

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

Copy link
Contributor

github-actions bot commented Sep 30, 2025

Size Change: 0 B

Total Size: 3.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.05 MB

compressed-size-action

@robbie-c robbie-c requested a review from a team October 1, 2025 10:03
@robbie-c robbie-c marked this pull request as ready for review October 1, 2025 10:03
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@robbie-c robbie-c enabled auto-merge (squash) October 1, 2025 13:14
@robbie-c robbie-c disabled auto-merge October 8, 2025 13:14
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@Twixes
Copy link
Member

Twixes commented Oct 11, 2025

(I did push a commit to make it more sci-fi)

@Twixes Twixes enabled auto-merge (squash) October 11, 2025 09:40
@robbie-c robbie-c force-pushed the feat/say-done-after-generate-demo-data branch from 39c0415 to 6d4648c Compare October 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants