-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix bugs in deploy hobby and CI #39073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…prove droplet name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
This PR can be merged, it fixes the issue that CI hobby for PRs is always testing the master head and not the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes critical bugs in the hobby deployment CI pipeline that were preventing proper testing of pull requests. The main issue was that the hobby CI was testing the most recent commit instead of the actual PR being submitted.
- Fixed hobby CI to test the correct commit hash from the PR branch
- Swapped the commit hash parameter between create and test commands to ensure proper deployment and testing
- Added proper branch reference to the create command for accurate testing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Problem
Posthog newbie here. I tried to follow the hobby install an ran into some problems, which was somehow expected.
Being not so sure about the status and what commit to use, I started digging and found that you actually run
a smoke test for the hobby deploy with every pull request. Very cool!
Digging deeper I found a few problems:
Details on the first point:
hobby-ci.py create
is creating the droplet and also deploying PostHog within the cloud init scripthobby-ci.py test COMMIT-HASH
does just wait until PostHog becomes live on http. The commit hash is ignored.When inspecting the
cloud-init-output.log
, you will see:Changes
The PR is work in progress. I plan to do:
posthog.cc
, so I can do testingWhen progressing I will most likely touch
bin/hobby-ci.py
,bin/deploy-hobby
,.github/workflows/ci-hobby.yml
.You can merge early or wait until complete.
How did you test this code?
I am testing
hobby-ci.py create
with our own Digital Ocean droplet.