-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(demo): make demo user staff by default + use system theme #39789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey @thmsobrmlr! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
action="store_true", | ||
default=False, | ||
help="Create a staff user", | ||
default=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: "Wether" is misspelled
default=True, | |
help="Whether the demo user should be a staff user (default: True)", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/management/commands/generate_demo_data.py
Line: 84:84
Comment:
**syntax:** "Wether" is misspelled
```suggestion
help="Whether the demo user should be a staff user (default: True)",
```
How can I resolve this? If you propose a fix, please make it concise.
default=False, | ||
help="Create a staff user", | ||
default=True, | ||
help="Wether the demo user should be a staff user (default: True)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the help text: Wether
should be Whether
.
help="Wether the demo user should be a staff user (default: True)", | |
help="Whether the demo user should be a staff user (default: True)", |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Problem
Follow up to #39711
Changes
How did you test this code?
Re-created my local environment