fix(experiments): Adjust fingerprint computation #39791
Open
+22
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I've made a mistake when setting up the
compute_metric_fingerprint method
. Right now, it includes the entirestats_config
object in the computation, when all we really care about is thestats.method
. Going forward this will be problematic - if we add any new fields tostats_config
, this will invalidate existing fingerprints.Changes
Instead of
stats_config
, only includestats_config.method
in the fingerprint.This will invalidate timeseries data in ~20 production experiments. I will manually run recalculations for them.
How did you test this code?
Updated tests