Skip to content

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Oct 16, 2025

Problem

Some secret fields weren't marked as secret's

Changes

  • Mark them as secret fields based on a list of RESERVED_FIELD_NAMES

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

@MarconLP MarconLP changed the title fix(msg): fix(msg): segment destinations make fields secret based on list Oct 16, 2025
@MarconLP MarconLP requested a review from a team October 16, 2025 16:15
@MarconLP MarconLP marked this pull request as ready for review October 16, 2025 16:15
@posthog-bot posthog-bot requested a review from a team October 16, 2025 16:17
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

'oauth2',
'accesstoken',
'access-token',
'acccess_token',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: typo in acccess_token - should be access_token (three c's instead of two)

Suggested change
'acccess_token',
'access_token',
Prompt To Fix With AI
This is a comment left during a code review.
Path: plugin-server/src/cdp/segment/segment-templates.ts
Line: 370:370

Comment:
**syntax:** typo in `acccess_token` - should be `access_token` (three c's instead of two)

```suggestion
    'access_token',
```

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants