fix(retention): mark custom bracket cells as in-progress when window hasn't elapsed

[okxint]

Problem

Custom retention bracket columns show 0% instead of graying out with "Period in progress" for cohorts whose bracket window hasn't fully closed yet. For example, with brackets [1, 3, 4, 8] weeks and a cohort starting Feb 1 2026, the "weeks 9–16" column shows 0% on May 17 even though the window doesn't close until May 24.

Individual period columns correctly detect in-progress state by comparing the cell date against today. The same logic was never applied to custom bracket columns.

Fixes #58679

Changes

In retentionLogic.ts, the isCurrentPeriod calculation is updated to handle custom brackets:

• Individual periods (unchanged): cellDate.isSame(now, periodUnit) — marks the current period column
• Custom brackets (new): A bracket cell is in-progress when its END period offset (cumulative sum of all bracket sizes up to that index) is still after today — i.e. cohort_date + bracketEndOffset > now

Example with brackets [1, 3, 4, 8] weeks, cohort Feb 1 2026, today May 17 2026:

• Index 4 → bracketEndOffset = 1+3+4+8 = 16 → end date = Feb 1 + 16 weeks = May 24 → isAfter(now) → in-progress ✓

How did you test this code?

Automated: TypeScript compilation passes. The logic change is isolated to the isCurrentPeriod computation inside retentionLogic.ts. Manual testing requires a retention insight with custom brackets and a cohort whose latest bracket window straddles today.

Publish to changelog?

No

🤖 Agent context

Authored with Claude Code. Root cause traced to retentionLogic.ts — the per-value isCurrentPeriod check used cellDate.isSame(now, periodUnit) uniformly, but for custom brackets cellDate is the bracket's start, not end. The fix accumulates bracket sizes to find the bracket's true end date and compares that against now.

[greptile-apps]

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
frontend/src/scenes/feature-flags/cohortPickerProps.ts:20-23
The constant name `COHORTS_ONLY_SUPPORT_IN_PICKER_PROPS` now contradicts its implementation — the `not_in` operator is no longer excluded, so the "ONLY_SUPPORT_IN" part of the name is false. The comment was correctly updated to explain the change, but the exported name itself is used at three call sites and will mislead future readers into thinking the preset still restricts to `in`-only.

```suggestion
export const COHORTS_PICKER_PROPS = {
    excludedOperators: { [TaxonomicFilterGroupType.Cohorts]: [] as PropertyOperator[] },
    selectingKeyOnly: { [TaxonomicFilterGroupType.Cohorts]: true },
}
```

### Issue 2 of 2
frontend/src/scenes/retention/retentionLogic.ts:198-205
**Multiple brackets marked in-progress simultaneously**

For custom brackets, `bracketEndDate.isAfter(now)` will be `true` for every bracket whose end period is still in the future — not just the bracket currently straddling today. For example, with brackets `[1, 3, 4, 8]` and a cohort from 2 weeks ago, both the third and fourth brackets would have `isCurrentPeriod = true`. Individual periods only ever mark one cell in-progress. This may be intentional (all open windows should grey out), but worth confirming the UI handles multiple `isCurrentPeriod = true` values in the same row gracefully.

_{Reviews (1): Last reviewed commit: "fix(retention): mark custom bracket cell..." | Re-trigger Greptile}

[greptile-apps]

The constant name COHORTS_ONLY_SUPPORT_IN_PICKER_PROPS now contradicts its implementation — the not_in operator is no longer excluded, so the "ONLY_SUPPORT_IN" part of the name is false. The comment was correctly updated to explain the change, but the exported name itself is used at three call sites and will mislead future readers into thinking the preset still restricts to in-only.

Suggested change

	export const COHORTS_ONLY_SUPPORT_IN_PICKER_PROPS = {
	excludedOperators: { [TaxonomicFilterGroupType.Cohorts]: [PropertyOperator.NotIn] },
	excludedOperators: { [TaxonomicFilterGroupType.Cohorts]: [] as PropertyOperator[] },
	selectingKeyOnly: { [TaxonomicFilterGroupType.Cohorts]: true },
	}
	export const COHORTS_PICKER_PROPS = {
	excludedOperators: { [TaxonomicFilterGroupType.Cohorts]: [] as PropertyOperator[] },
	selectingKeyOnly: { [TaxonomicFilterGroupType.Cohorts]: true },
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/scenes/feature-flags/cohortPickerProps.ts
Line: 20-23

Comment:
The constant name `COHORTS_ONLY_SUPPORT_IN_PICKER_PROPS` now contradicts its implementation — the `not_in` operator is no longer excluded, so the "ONLY_SUPPORT_IN" part of the name is false. The comment was correctly updated to explain the change, but the exported name itself is used at three call sites and will mislead future readers into thinking the preset still restricts to `in`-only.

```suggestion
export const COHORTS_PICKER_PROPS = {
    excludedOperators: { [TaxonomicFilterGroupType.Cohorts]: [] as PropertyOperator[] },
    selectingKeyOnly: { [TaxonomicFilterGroupType.Cohorts]: true },
}
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Multiple brackets marked in-progress simultaneously

For custom brackets, bracketEndDate.isAfter(now) will be true for every bracket whose end period is still in the future — not just the bracket currently straddling today. For example, with brackets [1, 3, 4, 8] and a cohort from 2 weeks ago, both the third and fourth brackets would have isCurrentPeriod = true. Individual periods only ever mark one cell in-progress. This may be intentional (all open windows should grey out), but worth confirming the UI handles multiple isCurrentPeriod = true values in the same row gracefully.

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/scenes/retention/retentionLogic.ts
Line: 198-205

Comment:
**Multiple brackets marked in-progress simultaneously**

For custom brackets, `bracketEndDate.isAfter(now)` will be `true` for every bracket whose end period is still in the future — not just the bracket currently straddling today. For example, with brackets `[1, 3, 4, 8]` and a cohort from 2 weeks ago, both the third and fourth brackets would have `isCurrentPeriod = true`. Individual periods only ever mark one cell in-progress. This may be intentional (all open windows should grey out), but worth confirming the UI handles multiple `isCurrentPeriod = true` values in the same row gracefully.

How can I resolve this? If you propose a fix, please make it concise.