fix: hasSingleUnnamedParam incorrectly matching named parameters #4553
+30
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hasSingleUnnamedParam function was only checking the parameter type but not whether the parameter actually had no name.
This is just a minor bug, since it only cause a less precise error message than if adding the
ppName == memptycheck so functions with named parameters don't incorrectly match the single-param fallback.Eror before Fix:
{ "code": "42883", "message": "function test.named_json_param() does not exist", "details": null, "hint": "No function matches the given name and argument types..." }Error after fix:
{ "code": "PGRST202", "message": "Could not find the function test.named_json_param(A, B, C) in the schema cache", "details": "Searched for the function test.named_json_param with parameters A, B, C or with a single unnamed json/jsonb parameter, but no matches were found in the schema cache.", "hint": null }