codeql PEP8 first argument should be self

[jsoref]

Short description

codeql complains (per PEP8) when the first argument to methods is not self: https://github.com/check-spelling-sandbox/pdns/security/quality/rules/py%2Fnot-named-self

Checklist

I have:

• read the CONTRIBUTING.md document
• read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)
• checked that this code was merged to master

[miodvallat]

As someone who always types slef when trying to type self, I am strongly opposed to that PR.

[pieterlexis]

Hey @jsoref,

Do you intend to finish this PR? Or should one of us pick this up?

[jsoref]

Please pick it up.

[pieterlexis]

I just rebased this on master and updated several callbacks to staticmethods. Now putting it through the CI paces. I'll add a PEP-8 check later as well.

[coveralls]

Coverage Report for CI Build 27534638053

Coverage increased (+0.02%) to 71.093%

Details

• Coverage increased (+0.02%) from the base build.
• Patch coverage: No coverable lines changed in this PR.
• 49 coverage regressions across 11 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

49 previously-covered lines in 11 files lost coverage.

Top 10 Files by Coverage Loss	Lines Losing Coverage	Coverage
pdns/recursordist/test-syncres_cc1.cc	11	79.9%
pdns/recursordist/syncres.cc	8	81.31%
pdns/rcpgenerator.cc	5	89.29%
pdns/dnsdistdist/dnsdist-carbon.cc	4	59.8%
pdns/dnsdistdist/dnsdist-lbpolicies.cc	4	73.87%
pdns/dnsdistdist/dnsdist-tcp.cc	4	74.59%
pdns/misc.cc	4	61.78%
modules/gpgsqlbackend/spgsql.cc	3	63.78%
pdns/iputils.cc	3	60.18%
pdns/recursordist/negcache.hh	2	90.63%

---

Coverage Stats

Relevant Lines:	171240
Covered Lines:	133419
Line Coverage:	77.91%
Relevant Branches:	81876
Covered Branches:	46528
Branch Coverage:	56.83%
Branches in Coverage %:	Yes
Coverage Strength:	6628444.24 hits per line

---

💛 - Coveralls

[pieterlexis]

ugh, the signoffs disappeared during the rebase and amends.