dnsdist: Add recvmmsg support for backend responses#16932
Draft
rgacogne wants to merge 1 commit into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
miodvallat
reviewed
Feb 26, 2026
rgacogne
force-pushed
the
ddistrecvmmsg-from-backends
branch
from
7548175 to
2d44918
Compare
Coverage Report for CI Build 27758512668Coverage increased (+0.01%) to 71.085%Details
Uncovered Changes
Coverage Regressions39 previously-covered lines in 12 files lost coverage.
Coverage Stats
💛 - Coveralls |
rgacogne
commented
Apr 2, 2026
| for (const auto& sockDesc : sockets) { | ||
| /* block until we have at least one message ready, but return | ||
| as many as possible to save the syscall costs */ | ||
| msgsGot = recvmmsg(sockDesc, msgVec.data(), vectSize, MSG_WAITFORONE | MSG_TRUNC, nullptr); |
Member
Author
There was a problem hiding this comment.
Suggested change
| msgsGot = recvmmsg(sockDesc, msgVec.data(), vectSize, MSG_WAITFORONE | MSG_TRUNC, nullptr); | |
| msgsGot = recvmmsg(sockDesc, msgVec.data(), vectSize, MSG_WAITFORONE, nullptr); |
| { | ||
| #ifndef DISABLE_RECVMMSG | ||
| #if defined(HAVE_RECVMMSG) && defined(HAVE_SENDMMSG) && defined(MSG_WAITFORONE) | ||
| if (dnsdist::configuration::getImmutableConfiguration().d_udpVectorSize > 0) { |
Member
Author
There was a problem hiding this comment.
Suggested change
| if (dnsdist::configuration::getImmutableConfiguration().d_udpVectorSize > 0) { | |
| if (dnsdist::configuration::getImmutableConfiguration().d_udpVectorSize > 1) { |
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
rgacogne
force-pushed
the
ddistrecvmmsg-from-backends
branch
from
2d44918 to
cd6a196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Needs testing, especially performance testing, documentation and perhaps even a switch in the configuration.
Closes #16625
Checklist
I have: