WIP: configurable extension for RRSIG expiry#17321
Conversation
pieterlexis
left a comment
There was a problem hiding this comment.
Please add documentation.
|
Would it be worth limiting the values to a reasonable range of seconds? Something like [minus one week; one year] maybe. |
dadbe20 to
b1d5faa
Compare
Yes: users will regret anything over minus one or two weeks. No: it's just rope. We don't do the hanging. That all said, generating a value before Inception is invalid anyway, so a -3 week lower bound makes sense to me. |
Coverage Report for CI Build 25757017830Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.2%) to 66.388%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions9548 previously-covered lines in 119 files lost coverage.
Coverage Stats💛 - Coveralls |
Short description
This goes well with #17281 but can exist separately.
Checklist
I have: