rec: keep cache warm for a list of names#17360
Draft
omoerbeek wants to merge 11 commits into
Draft
Conversation
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com> Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
…half the TTL has passed Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
miodvallat
reviewed
May 13, 2026
| log->error(Logr::Warning, e.reason, msg, "exception", Logging::Loggable("ImmediateServFailException")); | ||
| ret.clear(); | ||
| } | ||
| catch (const PolicyHitException& e) { |
Contributor
There was a problem hiding this comment.
Suggested change
| catch (const PolicyHitException& e) { | |
| catch (const PolicyHitException&) { |
| bool haveAnswerRecord = false; | ||
| for (const auto& record : ret) { | ||
| if (record.d_place == DNSResourceRecord::ANSWER) { | ||
| haveAnswerRecord = true; |
|
|
||
| static std::atomic<uint32_t> s_counter; | ||
|
|
||
| // Use primes, it avoid not being scheduled in cases where the counter has a regular pattern. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Use primes, it avoid not being scheduled in cases where the counter has a regular pattern. | |
| // Use primes, they avoid not being scheduled in cases where the counter shows a regular pattern. |
Coverage Report for CI Build 25805322127Coverage decreased (-2.9%) to 68.18%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2059 previously-covered lines in 60 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This is different from refresh-on-ttl-perc as it does not require a name/qtype to be queried to kick the refresh.
List is a
keepwarmkey in therecordcachesection. Value is a list, for example:If you have lots of names in the list you'll see
taskqueue-expiredgrow andtaskqueue-sizenever hitting zero. In that case increase the newrecursor.taskthreadssetting.Draft as tests and docs are missing.
Checklist
I have: