Skip to content

dnsdist-2.1: Backport 17469 - Consistently handle slow protobuf messages in our tests#17477

Open
rgacogne wants to merge 2 commits into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17469
Open

dnsdist-2.1: Backport 17469 - Consistently handle slow protobuf messages in our tests#17477
rgacogne wants to merge 2 commits into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17469

Conversation

@rgacogne
Copy link
Copy Markdown
Member

Short description

Backport #17469

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

rgacogne added 2 commits May 29, 2026 10:56
It was not an issue before, but GH actions runners are so bad these
days that we are now encountering these errors quite often.
In any case we should have been more consistent to begin with.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 6d1bbe0)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit ca45be9)
@rgacogne rgacogne added this to the dnsdist-2.1.0 milestone May 29, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26628297948

Coverage increased (+0.7%) to 68.904%

Details

  • Coverage increased (+0.7%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 9 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

9 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
pdns/tcpiohandler.cc 9 57.08%

Coverage Stats

Coverage Status
Relevant Lines: 70995
Covered Lines: 54101
Line Coverage: 76.2%
Relevant Branches: 30740
Covered Branches: 15998
Branch Coverage: 52.04%
Branches in Coverage %: Yes
Coverage Strength: 2734730.2 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants