[IMPROVEMENT] Update ruff rule: "PT"#235
Merged
Merged
Conversation
furqan463
commented
Apr 21, 2026
vincentkoppen
requested changes
Apr 30, 2026
Member
vincentkoppen
left a comment
vincentkoppen
left a comment
There was a problem hiding this comment.
Thanks again for the nice PR!
Some questions and suggestions on this one.
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
vincentkoppen
approved these changes
Apr 30, 2026
Member
vincentkoppen
left a comment
vincentkoppen
left a comment
There was a problem hiding this comment.
Looks good!
One small merge conflict, but good to go apart from that.
Signed-off-by: Engr. Ahmad Furqan <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Thijss
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
Changes proposed in this PR include:
Added ruff rule: "PT"