fix: Improve logic around grid.get_branches() for better performance#245
Merged
vincentkoppen merged 3 commits intoMay 7, 2026
Merged
Conversation
added 2 commits
May 7, 2026 09:45
I, JOHAN <johan.meppelink@alliander.com>, hereby add my Signed-off-by to this commit: c859549 Signed-off-by: JOHAN <johan.meppelink@alliander.com>
Thijss
changed the title
vincentkoppen
approved these changes
May 7, 2026
vincentkoppen
left a comment
vincentkoppen
left a comment
Member
There was a problem hiding this comment.
Nice improvement, thanks!
Looks good to me as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
Changes proposed in this PR include
Concatenate once is faster. So we now prepare the arrays in the list and concatenate once instead of concatenate each individually. This will help speed-up the get_branches function.