Skip to content

change: make input data private#66

Merged
Thijss merged 3 commits into
mainfrom
feature/issue-65-private-input-data
Jul 17, 2025
Merged

change: make input data private#66
Thijss merged 3 commits into
mainfrom
feature/issue-65-private-input-data

Conversation

@jaapschoutenalliander

@jaapschoutenalliander jaapschoutenalliander commented May 27, 2025

Copy link
Copy Markdown
Member

To prevent #65

Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com>
Signed-off-by: jaapschoutenalliander <jaap.schouten@alliander.com>
@sonarqubecloud

Copy link
Copy Markdown

@jaapschoutenalliander jaapschoutenalliander marked this pull request as ready for review May 30, 2025 07:53
@Thijss Thijss added the do-not-merge This should not be merged label Jun 5, 2025
@Thijss Thijss removed the do-not-merge This should not be merged label Jun 18, 2025

@Thijss Thijss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sonarqubecloud

Copy link
Copy Markdown

@Thijss Thijss merged commit fdac484 into main Jul 17, 2025
22 checks passed
@Thijss Thijss deleted the feature/issue-65-private-input-data branch July 17, 2025 14:55
@Thijss Thijss changed the title feat: make input data private chore: make input data private Jul 18, 2025
@Thijss Thijss changed the title chore: make input data private change: make input data private Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Make input_data in PowerGridModelInterface a private attribute

2 participants