Skip to content

feat(Flame Comics): add metadata and presence functionality #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DDH2004
Copy link

@DDH2004 DDH2004 commented Apr 10, 2025

Description

Added presence for flamecomics.xyz

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

"url":
"flamecomics.xyz",
"regExp": "flamecomics\\.xyz.*",
"version": "2.0.3",

Check failure

Code scanning / PMD

Makes sure the version is bumped Error

Expected initial version of activity Flame Comics to be 1.0.0
"flamecomics.xyz",
"regExp": "flamecomics\\.xyz.*",
"version": "2.0.3",
"logo": "https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png",

Check failure

Code scanning / PMD

Makes sure all images (logo and URLs) are exactly 512x512 pixels Error

Failed to validate image URL (https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png): Response code 404 (Not Found)

const presence = new Presence({ clientId: '864304063804997702' })
const browsingTimestamp = Math.floor(Date.now() / 1000)
const FLAME_COMICS_LOGO = 'https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png'

Check failure

Code scanning / PMD

Makes sure all images (logo and URLs) are exactly 512x512 pixels Error

Failed to validate image URL (https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png): Response code 404 (Not Found)
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, just use an imgur or other service to host the logo

Copy link
Contributor

This PR has been marked as stale because it has been inactive for over 14 days.
If you believe this PR is still relevant, please leave a comment to let us know.
Otherwise, this PR may be closed automatically in 7 days.

@github-actions github-actions bot added the inactive PR/Issue has been inactive for a while and will be closed soon label Apr 30, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

This PR has been automatically closed due to inactivity for over 14 days.
If you believe this PR is still relevant, feel free to reopen it or create a new one with updated information.

@github-actions github-actions bot closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activity update inactive PR/Issue has been inactive for a while and will be closed soon
Development

Successfully merging this pull request may close these issues.

3 participants