-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(Flame Comics): add metadata and presence functionality #9468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"url": | ||
"flamecomics.xyz", | ||
"regExp": "flamecomics\\.xyz.*", | ||
"version": "2.0.3", |
Check failure
Code scanning / PMD
Makes sure the version is bumped Error
"flamecomics.xyz", | ||
"regExp": "flamecomics\\.xyz.*", | ||
"version": "2.0.3", | ||
"logo": "https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png", |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
|
||
const presence = new Presence({ clientId: '864304063804997702' }) | ||
const browsingTimestamp = Math.floor(Date.now() / 1000) | ||
const FLAME_COMICS_LOGO = 'https://cdn.rcd.gg/PreMiD/websites/F/Flame%20Comics/assets/logo.png' |
Check failure
Code scanning / PMD
Makes sure all images (logo and URLs) are exactly 512x512 pixels Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, just use an imgur or other service to host the logo
This PR has been marked as stale because it has been inactive for over 14 days. |
This PR has been automatically closed due to inactivity for over 14 days. |
Description
Added presence for flamecomics.xyz
Acknowledgements
npm run lint
Screenshots
Proof showing the creation/modification is working as expected