Skip to content

feat(SoundCloud): Added "Show Artist as Prescence" option #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theusaf merged 2 commits into from
May 6, 2025
Merged

feat(SoundCloud): Added "Show Artist as Prescence" option #9541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f20f48a
feat(SoundCloud): add "Show Artist as Presence" option (#9533)
ccmdi May 5, 2025
c432226
fix(SoundCloud): Resolve linter issue
ccmdi May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions websites/S/SoundCloud/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"zh-tw": "SoundCloud是一個線上音樂分享平臺，它允許人們合作、交流和分享原創音樂錄音。"
},
"url": "soundcloud.com",
"version": "2.5.6",
"version": "2.5.7",
"logo": "https://cdn.rcd.gg/PreMiD/websites/S/SoundCloud/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/S/SoundCloud/assets/thumbnail.jpg",
"color": "#FF7E30",
Expand Down Expand Up @@ -78,10 +78,16 @@
"value": true
},
{
"id": "usePresenceName",
"id": "usePresenceTitle",
"title": "Show Title as Presence",
"icon": "fad fa-user-edit",
"value": false
},
{
"id": "usePresenceArtist",
"title": "Show Artist as Presence",
"icon": "fad fa-user-edit",
"value": false
}
]
}
14 changes: 11 additions & 3 deletions websites/S/SoundCloud/presence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ presence.on('UpdateData', async () => {
showTimestamps,
showCover,
showButtons,
usePresenceName,
usePresenceTitle,
usePresenceArtist,
newLang,
] = await Promise.all([
presence.getSetting<boolean>('browse'),
Expand All @@ -129,7 +130,8 @@ presence.on('UpdateData', async () => {
presence.getSetting<boolean>('timestamp'),
presence.getSetting<boolean>('cover'),
presence.getSetting<boolean>('buttons'),
presence.getSetting<boolean>('usePresenceName'),
presence.getSetting<boolean>('usePresenceTitle'),
presence.getSetting<boolean>('usePresenceArtist'),
presence.getSetting<string>('lang').catch(() => 'en'),
])
const playing = Boolean(document.querySelector('.playControls__play.playing'))
Expand All @@ -154,12 +156,18 @@ presence.on('UpdateData', async () => {
}

if ((playing || (!playing && !showBrowsing)) && showSong) {
if (!usePresenceName) {
if (!usePresenceTitle && !usePresenceArtist) {
presenceData.details = getElement(
'.playbackSoundBadge__titleLink > span:nth-child(2)',
)
presenceData.state = getElement('.playbackSoundBadge__lightLink')
}
else if (usePresenceArtist && !usePresenceTitle) {
presenceData.name = getElement('.playbackSoundBadge__lightLink')
presenceData.details = getElement(
'.playbackSoundBadge__titleLink > span:nth-child(2)',
)
}
else {
presenceData.name = getElement(
'.playbackSoundBadge__titleLink > span:nth-child(2)',
Expand Down
Loading