B032 correlation id webhooks - #735
Merged
greatest0fallt1me merged 4 commits intoJul 29, 2026
Merged
Conversation
|
@ugoocreates-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
CI green, LGTM ✨ merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #606
This PR implements
X-Correlation-Idgeneration and propagation for the/api/webhooksendpoint and subsequent outbound webhook dispatches. It ensures end-to-end traceability for webhook management and event deliveries.Problem Statement
The
/api/webhooksendpoint lacked consistent correlation ID tracking, meaning webhook subscription creations, updates, and dispatches could not be traced across distributed boundaries. This made debugging dropped webhooks or misconfigurations difficult.Solution
correlationMiddlewareto the webhooks router. This extracts existing correlation IDs from incoming headers or generates new ones if missing.correlationIdinto all route-level logging.correlationIdinside the standardized API error envelope for client visibility.globalThis.fetchincorrelation.tsto automatically inject theX-Correlation-Idheader into all outbound network calls (including webhook deliveries) when an active AsyncLocalStorage context with a correlation ID is present.Changes
1. src/routes/webhooks.ts
correlationMiddlewareto the webhooks router chain.correlationIdviagetCorrelationId()in all handlers.correlationIdtologger.info,logger.warn, andlogger.debugcalls.RouteErrorFactory.validationcatch blocks to returncorrelationIdinside the error response.2. src/middleware/correlation.ts
globalThis.fetch.fetchautomatically get theX-Correlation-Idheader.Security Considerations
Testing
Acceptance Criteria
X-Correlation-Idis present in webhooks handlers and outbound calls.