fix(users): add graceful timeout with 504 on /api/users (#604) - #740
Merged
greatest0fallt1me merged 1 commit intoJul 29, 2026
Merged
Conversation
…rg#604) Change the per-request timeout on /api/users from default 408 to 504 Gateway Timeout with cooperative abort, per issue Predictify-org#604. Also fix pre-existing bugs in tags.ts (missing zod import) and markets/index.ts (duplicate trackMarketsMetrics declarations) that blocked the test suite from importing createApp. Closes Predictify-org#604
|
@Obaara293 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
Nice work — merging. Appreciate the polish! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the per-request timeout on
/api/usersfrom the default 408 to 504 Gateway Timeout with cooperative abort, per the requirements in issue #604. It also fixes two pre-existing bugs intags.tsandmarkets/index.tsthat blocked the test suite from importingcreateApp.Related Issue
Closes #604
Changes
Timeout on /api/users
src/routes/users.ts— Changed fromrequestTimeout(15000)(default 408) to explicit 504 withcode: "gateway_timeout"andmessage: "Request timed out"tests/usersTimeout.test.ts— Focused test suite verifying 504 gateway_timeout when the service hangs, and normal 200 response when within deadlinePre-existing bug fixes
src/routes/tags.ts— Added missing imports forzod,logger,getMarketTags, and Express typessrc/routes/markets/index.ts— Removed duplicatetrackMarketsMetricsdeclarations (was defined 3 times)Verification Results