Add zod input validation for /api/devices (#621) - #742
Merged
greatest0fallt1me merged 1 commit intoJul 29, 2026
Merged
Conversation
- Create src/validators/devices.ts with listDevicesQuerySchema and deviceIdParamSchema, following existing validator patterns - Add Zod query validation to GET /api/me/devices (rejects unknown params) - Refactor POST /api/me/devices/:id/revoke to import schema from validators and throw ZodError directly for consistent 400 validation_error response - Add tests for unknown query param rejection - Wire errorHandler into test apps for proper error response handling
|
@ByteForce-Labs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Closes #621 (auto-added on behalf of @ByteForce-Labs so the linked issue closes on merge) |
Contributor
|
LGTM ✅ green CI, clean work — merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Zod input validation for the
/api/devicesendpoints with structured 400 errors.Changes
src/validators/devices.ts(new)listDevicesQuerySchema— validates GET query params (empty, rejects unknown via.strict())deviceIdParamSchema— validates POST:idpath param as UUIDz.infer<>src/routes/devices.tsreq.querywithlistDevicesQuerySchema.safeParse(); throws ZodError on failuresrc/routes/devicesRevoke.tsparamsSchemawith importeddeviceIdParamSchemafrom validatorsparsed.error(ZodError) directly instead ofRouteErrorFactory.validation(), producing consistent 400 withvalidation_errorcodetests/devices.test.tsvalidation_error)errorHandlermiddleware into test apptests/devicesRevoke.test.tserrorHandlermiddleware into test appTest coverage
All 6 devices tests pass (3 list, 3 revoke), including new validation coverage for unknown query params and malformed UUIDs.
Closes #621