feat(#1398): implement event creation idempotency with fee protection - #1420
Merged
greatest0fallt1me merged 1 commit intoAug 29, 2026
Conversation
…fee protection Closes Predictify-org#1398 ## Summary Implement caller-supplied idempotency keys for event creation to prevent duplicate event-creation fee charges on retry scenarios (e.g., after network timeout or partial failure). ## Changes ### Storage Infrastructure - Add `CreateEventIdem(Address, BytesN<32>)` to DataKey enum in storage.rs - Scoped by admin address + caller-supplied 32-byte key - TTL: ~7 days (reuses PLACE_BETS_IDEM_TTL_LEDGERS constant) ### Core Implementation (lib.rs) - Add optional `idempotency_key: Option<BytesN<32>>` parameter to create_event - Idempotency check BEFORE any state mutations: - If duplicate key found: return IdempotentBatchAlreadyApplied error - If fresh key: proceed with fee collection and event creation - Integrate fee collection via process_creation_fee (was previously missing) - Store idempotency key with TTL after successful event creation ### Behavior - **First call**: Event created, fee charged, key stored - **Retry (same key, within TTL)**: IdempotentBatchAlreadyApplied error, NO fee - **After TTL expiry**: Key reusable for new event creation - **No key provided**: Works as before (backward compatible) ## Failure Mode Safety - Idempotency check fires BEFORE fee collection → no duplicate fees on retry - Key scope: admin-specific → different admins independent - Deterministic error response → clear signal to clients ## Acceptance Criteria ✓ Deterministic behavior for valid/invalid/duplicate/boundary inputs ✓ Authorization & validation still enforced before idempotency check ✓ Retries, partial failures safe from double-charging ✓ Key scope prevents collisions across admins ✓ Backward compatible: optional parameter ✓ Clear error codes and audit trail entries ## Testing Comprehensive test suite covers: - Happy path: fresh key creates event + charges fee - Duplicate detection: same key rejected, no fee - Key scoping: different admins independent - TTL expiry: key becomes reusable - Fee verification: charged exactly once - Regression: existing tests pass
|
@nlstylz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1398
Summary
Implement caller-supplied idempotency keys for event creation to prevent duplicate event-creation fee charges on retry scenarios (e.g., after network timeout or partial failure).
Changes
Storage Infrastructure
CreateEventIdem(Address, BytesN<32>)to DataKey enum in storage.rsCore Implementation (lib.rs)
idempotency_key: Option<BytesN<32>>parameter to create_eventBehavior
Failure Mode Safety
Acceptance Criteria
✓ Deterministic behavior for valid/invalid/duplicate/boundary inputs ✓ Authorization & validation still enforced before idempotency check ✓ Retries, partial failures safe from double-charging ✓ Key scope prevents collisions across admins
✓ Backward compatible: optional parameter
✓ Clear error codes and audit trail entries
Testing
Comprehensive test suite covers:
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀