改回老版本播放器控件#2186
Open
keyboard2005 wants to merge 1 commit into
Open
Conversation
Remove the standalone PlayerAdjustmentHud widget and replace it with lightweight inline overlay widgets in player_item_panel.dart and smallest_player_item_panel.dart. Update player_item.dart to replace the old adjustment HUD timer with hideVolumeUITimer, add _horizontalDragHold, simplify brightness/volume show/hide logic, and handle horizontal drag holds. Remove seekDirection from PlayerPanelController and adjust gesture handling accordingly. Overall: simplify HUD presentation, reduce indirection, and clean up related timers/holds.
Contributor
Author
|
@Predidit 你觉得可以吗 ， 这个提交包含了代码 |
Owner
|
我需要考虑一下这个PR，因为本身将 HUD 独立出来是期待的重构 |
Contributor
Author
我觉得没有必要 现在已经足够简单了 或者我可以提交一份独立HUD 但样式是老版本 的提交 你看怎么样？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
我看了你今天刚发布的版本， 只是临时吧加速指示器缩小了尺寸，和其他的指示器完全不协调， 我认为老版本指示器部分就足够简单足够好了，没有必要使用现在的新版。
加速指示器的推入效果很抢占注意力 哪怕是原地淡入也比推入要好，面对移动的物体注意力会被分散程度比原地出现要高，
当然这一切有可能也只是我的不习惯导致的， 但不习惯的人应该会很多。
#2139
#2164