fix: use dynamic version in CLI help text instead of hardcoded 2.0#3456
Open
saschabuehrle wants to merge 1 commit intoPrefectHQ:mainfrom
Open
fix: use dynamic version in CLI help text instead of hardcoded 2.0#3456saschabuehrle wants to merge 1 commit intoPrefectHQ:mainfrom
saschabuehrle wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
marvin-context-protocol
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#3455 — Running
fastmcp --helpdisplays "FastMCP 2.0" regardless of the installed version, which is confusing on 3.x.Fix
Replaced the hardcoded
"FastMCP 2.0"string in thecyclopts.Apphelp parameter with an f-string that readsfastmcp.__version__at import time. Theversion=kwarg already usesfastmcp.__version__, so this just makes the two consistent.Also updated the test in
test_cli.pyto assert"FastMCP"is present in the help text without checking a specific version number, matching the existing pattern used for theversionattribute.Testing
Confirmed the help text now shows the actual installed version. The existing test suite passes with the updated assertion.
Happy to address any feedback.
Greetings, saschabuehrle