fix typing for embedding_fn in postgres provider#1047
Merged
jlowin merged 2 commits intoPrefectHQ:mainfrom Jan 31, 2025
Merged
Conversation
for some reason OpenAIEmbeddings function isnt a Callable like ChatOpenAI provider , so if providing a custon non openAIEmbedding function (base_url , etc.) this would fail validation, it passed if you didnt have to change anything, setting it to OpenAIEmbeddings allows you to customize it
webcoderz
changed the title
jlowin
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some reason OpenAIEmbeddings function isnt a Callable like ChatOpenAI provider , so if providing a custon non openAIEmbedding function (base_url , etc.) this would fail validation, it passed if you didnt have to change anything, setting it to OpenAIEmbeddings allows you to customize it