Skip to content

feat(prefect-server): add appProtocol to service port#604

Open
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
lostkamp:add-app-protocol
Open

feat(prefect-server): add appProtocol to service port#604
lostkamp wants to merge 1 commit intoPrefectHQ:mainfrom
lostkamp:add-app-protocol

Conversation

@lostkamp
Copy link

@lostkamp lostkamp commented Mar 5, 2026

Summary

This is an optional field that sometimes enables additional capabilities by addons like Istio.

Docs: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol

I tried to make the usage optional in the template, not sure if this is correct actually.

Requirements

  • Contributing guide has been read
  • Title follows the conventional commits format
  • Body includes Closes <issue>, if available
  • Added/modified configuration includes a descriptive comment for documentation generation
  • Unit tests are added/updated
  • Deprecation/removal checks are added in templates/NOTES.txt
  • Relevant labels are added
  • Draft status is used until ready for review

@lostkamp lostkamp requested a review from a team as a code owner March 5, 2026 15:33
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@lostkamp lostkamp requested a deployment to Acceptance Tests (External) March 5, 2026 15:33 — with GitHub Actions Waiting
@mitchnielsen mitchnielsen changed the title fix(prefect-server): Add appProtocol to service port feat(prefect-server): add appProtocol to service port Mar 9, 2026
@mitchnielsen mitchnielsen self-requested a review March 9, 2026 18:30
@mitchnielsen
Copy link
Contributor

Thanks for the contribution! A couple of things before we can merge:

  1. The default in values.yaml should probably be "" (empty) rather than "http", so existing deployments aren't affected on upgrade.
  2. Could you add a unit test covering both the set and unset cases? You can look at existing tests in charts/prefect-server/tests/ for examples.
  3. Let's add a default to the schema entry to keep it in sync with values.yaml.

Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment requesting small changes 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants