You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mitchnielsen
changed the title
fix(server): set HOME en podSecuritycontext for migration job
fix(server): set HOME in podSecuritycontext for migration job
Mar 9, 2026
The HOME env var addition looks good. I believe the podSecurityContext implementation has a couple of issues that need fixing:
{{- include . | nindent 4 }} won't work because include expects a template name string, not a dict. The pattern used elsewhere in this chart is:
{{- with .Values.backgroundServices.podSecurityContext }}securityContext: {{- . | toYaml | nindent 8 }}{{- end }}
The second test case (Should set correct pod security context) is indented one level too deep, making it part of the previous test's asserts list rather than a separate test. It also needs a set: block to provide the values and to enable backgroundServices.runAsSeparateDeployment. You can see the test failure here and you should be able to run it locally to confirm it works before pushing up the commit.
Would you also consider adding migrations.podSecurityContext as its own values key (similar to how the migration job already has its own securityContext, affinity, tolerations, etc.) rather than pulling from backgroundServices? This would be more consistent with the existing pattern where the migration job has independent configuration.
The reason will be displayed to describe this comment to others. Learn more.
Left a comment requesting small changes 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #605
This change adds the following to the separate migrations job:
podSecurityContext, as specified in thebackgroundServicessectionRequirements
Closes <issue>, if availabletemplates/NOTES.txtDraftstatus is used until ready for review