Add ConfigMap permissions to operator ClusterRole#235
Merged
mitchnielsen merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
The operator needs to read ConfigMaps from any namespace where users deploy PrefectWorkPools or PrefectServers. This was missed when PR #194 added ConfigMap watching for base job templates - the controller calls `Watches(&corev1.ConfigMap{}, ...)` which requires cluster-wide list/watch permissions to sync the informer at startup. Without these permissions, the operator fails with RBAC errors and enters CrashLoopBackOff. Closes #234 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
chrisguidry
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The operator needs to read ConfigMaps from any namespace where users deploy PrefectWorkPools or PrefectServers. This was missed when PR #194 added ConfigMap watching for base job templates - the controller calls
Watches(&corev1.ConfigMap{}, ...)which requires cluster-wide list/watch permissions to sync the informer at startup.Without these permissions, the operator fails with RBAC errors and enters CrashLoopBackOff.
The existing unit tests didn't catch this because envtest doesn't enforce RBAC - it's a simulated API server that grants all permissions. This kind of issue only surfaces when deploying to a real cluster. To confirm this, I deployed to a local cluster:
Closes #234