Skip to content

[UI v2] feat: Updates combobox filtering logic for automations#16737

Merged
devinvillarosa merged 1 commit intomainfrom
filter-automation-list
Jan 16, 2025
Merged

[UI v2] feat: Updates combobox filtering logic for automations#16737
devinvillarosa merged 1 commit intomainfrom
filter-automation-list

Conversation

@devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 15, 2025

  1. Updates combobox to have developers to use our own filtering mechanism. When trying to integrate it with other data resources, it doesn't seem like we'll be using cmdk's built in filtering mechanics

  2. Updates AutomationsSelectStateFields component to use our own filtering mechanism. Because there is no API support for filtering by _like name, opting to do filtering on the client side

Screen.Recording.2025-01-15.at.12.37.52.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 15, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review January 15, 2025 20:55
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to .ts to resolve jsx re-rendering warning

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit 3b73ba3 into main Jan 16, 2025
7 checks passed
@devinvillarosa devinvillarosa deleted the filter-automation-list branch January 16, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui-replatform Related to the React UI rewrite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants