Skip to content

[UI v2] feat: Begin to create automation page #16747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devinvillarosa merged 1 commit into from
Jan 16, 2025
Merged

[UI v2] feat: Begin to create automation page #16747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions ui-v2/src/components/automations/automations-header/automations-header.tsx
View file
Open in desktop
Copy link
Contributor Author

@devinvillarosa devinvillarosa Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated aria-label and order of link vs button to resolve a11y violations

Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {
Breadcrumb,
BreadcrumbItem,
BreadcrumbLink,
BreadcrumbList,
} from "@/components/ui/breadcrumb";
import { Button } from "@/components/ui/button";
Expand All @@ -22,20 +21,20 @@ const Header = () => (
<div className="flex items-center gap-2">
<Breadcrumb>
<BreadcrumbList>
<BreadcrumbItem>
<BreadcrumbLink
to="/concurrency-limits"
className="text-xl font-semibold"
>
Automations
</BreadcrumbLink>
<BreadcrumbItem className="text-xl font-semibold">
Automations
</BreadcrumbItem>
</BreadcrumbList>
</Breadcrumb>
<Button size="icon" className="h-7 w-7" variant="outline">
<Link to="/automations/create">
<Link to="/automations/create" aria-label="create automation">
<Button
size="icon"
className="h-7 w-7"
variant="outline"
aria-label="create automation"
>
<Icon id="Plus" className="h-4 w-4" />
</Link>
</Button>
</Button>
</Link>
</div>
);
19 changes: 19 additions & 0 deletions ui-v2/src/components/automations/automations-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { buildListAutomationsQuery } from "@/api/automations";
import { useSuspenseQuery } from "@tanstack/react-query";
import { AutomationsEmptyState } from "./automations-empty-state";
import { AutomationsHeader } from "./automations-header";

export const AutomationsPage = () => {
const { data } = useSuspenseQuery(buildListAutomationsQuery());

return (
<div className="flex flex-col gap-4">
<AutomationsHeader />
{data.length === 0 ? (
<AutomationsEmptyState />
) : (
<div>TODO: AUTOMATIONS_LIST</div>
)}
</div>
);
};
7 changes: 2 additions & 5 deletions ui-v2/src/routes/automations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import { buildListAutomationsQuery } from "@/api/automations";
import { AutomationsPage } from "@/components/automations/automations-page";
import { createFileRoute } from "@tanstack/react-router";

// nb: Currently there is no filtering or search params used on this page
export const Route = createFileRoute("/automations/")({
component: RouteComponent,
component: AutomationsPage,
loader: ({ context }) =>
context.queryClient.ensureQueryData(buildListAutomationsQuery()),
wrapInSuspense: true,
});

function RouteComponent() {
return "🚧🚧 Pardon our dust! 🚧🚧";
}
Loading