Skip to content

don't make extra calls to cloud in prefect dashboard open#16768

Merged
zzstoatzz merged 6 commits intomainfrom
early-exit-dashboard
Jan 21, 2025
Merged

don't make extra calls to cloud in prefect dashboard open#16768
zzstoatzz merged 6 commits intomainfrom
early-exit-dashboard

Conversation

@zzstoatzz
Copy link
Collaborator

if cloud is down (like it was for maintenance) then prefect dashboard open hangs as it tries to find your workspace, but you're using OSS this shouldn't matter and it should exit early

stacked on #16767

@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Jan 18, 2025
@zzstoatzz zzstoatzz self-assigned this Jan 18, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2025

CodSpeed Performance Report

Merging #16768 will not alter performance

Comparing early-exit-dashboard (1e18e32) with main (e047607)

Summary

✅ 2 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review January 21, 2025 15:25
@desertaxle
Copy link
Member

Since the prefect dashboard open command immediately opens the browser, you often don't see the final output of the command. Could we just print the UI URL in all cases to avoid API calls entirely?

@zzstoatzz zzstoatzz force-pushed the early-exit-dashboard branch from 13e9b3c to 1e18e32 Compare January 21, 2025 16:12
@zzstoatzz
Copy link
Collaborator Author

Since the prefect dashboard open command immediately opens the browser, you often don't see the final output of the command. Could we just print the UI URL in all cases to avoid API calls entirely?

indeed i can! updated

@zzstoatzz zzstoatzz added the cli Related to the Prefect CLI label Jan 21, 2025
@zzstoatzz zzstoatzz merged commit 054370d into main Jan 21, 2025
47 checks passed
@zzstoatzz zzstoatzz deleted the early-exit-dashboard branch January 21, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to the Prefect CLI fix A fix for a bug in an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants