use task groups for concurrent queue consumers#16850
Merged
Conversation
8398b70 to
4c039ca
Compare
4c039ca to
5aba2f8
Compare
CodSpeed Performance ReportMerging #16850 will not alter performanceComparing Summary
|
1cba2cb to
ce7701b
Compare
6b90e6e to
0c6a3f8
Compare
4c26e2a to
f3283db
Compare
725a538 to
d13643f
Compare
chrisguidry
reviewed
Jan 28, 2025
Collaborator
chrisguidry
left a comment
There was a problem hiding this comment.
This all makes sense to me! The tests look great
83cb350 to
7f7152d
Compare
Contributor
daniel-prefect
left a comment
There was a problem hiding this comment.
Docs changes look good
Collaborator
Author
thanks! though this reminds me that I should have actually removed that new setting, this is removed now so there should be no doc-related changes here |
1c3aba2 to
0048f5a
Compare
desertaxle
approved these changes
Jan 29, 2025
Member
desertaxle
left a comment
There was a problem hiding this comment.
I left a couple nits, but this looks like an awesome enhancement!
oops rm needless diff
rm setting from test file
793d5ef to
009fd08
Compare
009fd08 to
719f7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #16299
the queue depth metrics were very useful while debugging and I could imagine they might be useful to server operators in the future, which I why I opted to keep it in - happy to re-evaluate this choice. doing so made me think that we may want to add more server metrics in the future