Skip to content

Add support for secure Mattermost notifications#16884

Merged
desertaxle merged 1 commit intoPrefectHQ:mainfrom
sochotnicky:add-mattermost-secure-support
Jan 29, 2025
Merged

Add support for secure Mattermost notifications#16884
desertaxle merged 1 commit intoPrefectHQ:mainfrom
sochotnicky:add-mattermost-secure-support

Conversation

@sochotnicky
Copy link
Contributor

Apprise supports this but we need to surface the configuration part and pass it on. Keeping default to insecure connection to not break compatibility, but perhaps worth reconsidering.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
    • I think this is small enough of a fix?
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Apprise supports this but we need to surface the configuration part.
Keeping default to insecure connection to not break compatibility, but
perhaps worth reconsidering.
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #16884 will not alter performance

Comparing sochotnicky:add-mattermost-secure-support (719aebf) with main (c2e0a1e)

Summary

✅ 2 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@desertaxle desertaxle merged commit bd807de into PrefectHQ:main Jan 29, 2025
53 checks passed
@desertaxle desertaxle added the enhancement An improvement of an existing feature label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants