Exclude site-packages from scanned dirs in prefect deploy#16885
Merged
Exclude site-packages from scanned dirs in prefect deploy#16885
site-packages from scanned dirs in prefect deploy#16885Conversation
CodSpeed Performance ReportMerging #16885 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
dont-search-site-packages
branch
2 times, most recently
from
50e9c19 to
be9ec7d
Compare
zzstoatzz
force-pushed
the
dont-search-site-packages
branch
2 times, most recently
from
e456d76 to
875866a
Compare
cicdw
requested changes
Jan 29, 2025
Member
cicdw
left a comment
cicdw
left a comment
There was a problem hiding this comment.
minor nit -- is this something that's easy enough to test?
src/prefect/cli/_prompts.py
Outdated
|
|
||
| Args: | ||
| directory: The directory to search in | ||
| exclude_patterns: List of patterns to exclude from the search. |
Member
There was a problem hiding this comment.
Since the default logic is within this function I think it makes sense to keep the default in the docstring - sorry if my message was confusing earlier!
zzstoatzz
force-pushed
the
dont-search-site-packages
branch
from
875866a to
657d840
Compare
Collaborator
Author
cicdw
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16882
excludes
**/site-packages/**usingfilter_files