Skip to content

Fix flaky UI v2 E2E tests: block-catalog, dashboard, dark-mode-contrast #21094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desertaxle merged 1 commit into from
Mar 11, 2026
+8 −4
Merged

Fix flaky UI v2 E2E tests: block-catalog, dashboard, dark-mode-contrast #21094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui-v2/e2e/blocks/block-catalog.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,14 @@ test.describe("Block Catalog", () => {
});
await expect(page.getByText(blockName)).toBeVisible({ timeout: 10000 });

// Increase polling timeout to avoid flakiness under CI load
await expect
.poll(
async () => {
const docs = await listBlockDocuments(apiClient);
return docs.find((d) => d.name === blockName);
},
{ timeout: 10000 },
{ timeout: 30000 },
)
.toBeDefined();
});
Expand Down
2 changes: 1 addition & 1 deletion ui-v2/e2e/dark-mode-contrast.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const EXCLUDED_SELECTORS = [
const KNOWN_LIGHT_MODE_VIOLATIONS: Record<string, number> = {
Dashboard: 0,
Flows: 0,
Runs: 4, // SCHEDULED, CRASHED, FAILED, COMPLETED badges
Runs: 5, // SCHEDULED, CRASHED, FAILED, COMPLETED badges + occasional extra under CI rendering
"Work Pools": 0,
Deployments: 0,
};
Expand Down
7 changes: 5 additions & 2 deletions ui-v2/e2e/dashboard/dashboard.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,19 @@ test.describe("Dashboard Page", () => {

// --- VERIFY: URL updates with hideSubflows parameter ---
await expect(page).toHaveURL(/hideSubflows=true/);
// Wait for the switch to reflect checked state before toggling again
await expect(hideSubflowsSwitch).toBeChecked();

// The dashboard should refresh and filter out subflows
// This is verified by the URL param change and the component re-rendering

// --- ACTION: Toggle hide subflows OFF ---
await hideSubflowsSwitch.click();

// --- VERIFY: URL no longer has hideSubflows=true ---
// --- VERIFY: Switch is unchecked and URL no longer has hideSubflows=true ---
await expect(hideSubflowsSwitch).not.toBeChecked();
// When false/default, the param should be removed or set to false
await expect(page).not.toHaveURL(/hideSubflows=true/);
await expect(page).not.toHaveURL(/hideSubflows=true/, { timeout: 10000 });
});

test("should persist date range selection in URL and filter dashboard data", async ({
Expand Down
Loading