chore: suppress pre-existing gosec lint warnings#658
Closed
mitchnielsen wants to merge 1 commit intomainfrom
Closed
chore: suppress pre-existing gosec lint warnings#658mitchnielsen wants to merge 1 commit intomainfrom
mitchnielsen wants to merge 1 commit intomainfrom
Conversation
These 4 warnings (G117 secret pattern, G704 SSRF) have been failing pre-commit hooks on every branch. The flagged code is safe: URLs come from provider config or CLI args, and the struct field is a JSON key.
mitchnielsen
had a problem deploying
to
Acceptance Tests
GitHub Actions
Failure
mitchnielsen
added
the
maintenance
jimid27
approved these changes
Mar 13, 2026
mitchnielsen
temporarily deployed
to
Acceptance Tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//nolint:gosecdirectives to 4 pre-existing warnings that have been failing pre-commit hooks on every branchAccessTokenstruct field is a JSON key, not a credentialSession context
These warnings were discovered while trying to commit an unrelated fix on another branch. The gosec linter was failing pre-commit hooks for all commits across all branches, blocking development.