Skip to content

fix(resources): reset deployment and block access to wildcard on deletion#659

Merged
mitchnielsen merged 2 commits intomainfrom
wildcard-on-deletion
Mar 17, 2026
Merged

fix(resources): reset deployment and block access to wildcard on deletion#659
mitchnielsen merged 2 commits intomainfrom
wildcard-on-deletion

Conversation

@mitchnielsen
Copy link
Member

@mitchnielsen mitchnielsen commented Mar 13, 2026

Summary

Same bug fixed in #652 for prefect_work_pool_access: when prefect_deployment_access or prefect_block_access resources are deleted, the Delete function was resetting actor IDs to [] (empty), which locks everyone out. Should be ["*"] to restore the default open access state.

Related to https://linear.app/prefect/issue/PLA-2466/fixresources-reset-deployment-access-and-block-access-to-wildcard-on

Requirements

General

  • The contributing guide has been read
  • Title follows the conventional commits format
  • Body includes Closes <issue>, if available
  • Relevant labels have been added
  • Draft status is used until ready for review

Code-level changes

  • Unit tests are added/updated
  • Acceptance tests are added/updated (including import tests, when needed)

…tion

Same bug as #652 (work_pool_access): deleting the resource set actor IDs
to empty, locking everyone out instead of restoring default open access.
Now resets actor IDs to ["*"] while leaving team IDs empty.
…and block access

Mirrors the test pattern from #652 (work_pool_access): a two-step
acceptance test that sets restricted access, removes the resource,
then verifies the API returns wildcard ["*"] access.
@mitchnielsen mitchnielsen marked this pull request as ready for review March 13, 2026 19:56
@mitchnielsen mitchnielsen requested a review from a team as a code owner March 13, 2026 19:56
@mitchnielsen mitchnielsen merged commit 03702bc into main Mar 17, 2026
8 of 9 checks passed
@mitchnielsen mitchnielsen deleted the wildcard-on-deletion branch March 17, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants