Develop#205
Conversation
…create ProjectSettings and Packages Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…-project-structure Restructure to standard Unity project layout
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…ntation Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…fix redundant checks, improve script examples Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
… branch mentions, fix doc link Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…cks-for-unity-project Add CI pipeline for Unity project validation
There was a problem hiding this comment.
Pull request overview
This PR sets up a Unity project structure suitable for GitHub Actions CI and adds a Unity CI workflow, alongside migrating/adding Unity project assets, settings, scripts, and documentation.
Changes:
- Added a GitHub Actions Unity CI workflow that checks
.metaconsistency, runs Unity tests, and builds for Linux. - Added/organized Unity project files under
Assets/,Packages/, andProjectSettings/, including many new gameplay/system scripts. - Updated docs (
README.md,docs/CONTRIBUTING.md) to reflect the new project workflow and CI guidance.
Reviewed changes
Copilot reviewed 26 out of 290 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/unity-ci.yml | Adds CI for meta validation, Unity tests, and Linux builds. |
| docs/CONTRIBUTING.md | Updates setup steps and adds local CI guidance link. |
| README.md | Adds quick-start and CI badge/documentation link. |
| Assets/Scripts/ui/InfoBox.cs | Introduces InfoBox base class for UI boxes. |
| Assets/Scripts/ui/boxes/*.cs | Adds multiple InfoBox UI implementations (player/market/inventory/etc). |
| Assets/Scripts/market/Market.cs | Adds market logic for stalls and trading. |
| Assets/Scripts/nation/NationNameGenerator.cs | Adds nation name generation utility. |
| Assets/Scripts/command/** | Adds gameplay commands (nation/settlement/interaction/etc). |
| Assets/Scripts/event/** | Adds event system types and event producers. |
| ProjectSettings/*, Packages/manifest.json | Adds Unity project configuration and package dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run Tests | ||
| uses: game-ci/unity-test-runner@v4 | ||
| env: | ||
| UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }} | ||
| UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }} | ||
| UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} | ||
| with: | ||
| unityVersion: 2022.3.7f1 | ||
| githubToken: ${{ secrets.GITHUB_TOKEN }} | ||
| checkName: Unity Test Results |
There was a problem hiding this comment.
This workflow runs game-ci/unity-test-runner, but the repo's test files under Assets/Scripts/Tests/** are not Unity Test Framework tests (no NUnit [Test] attributes were found), so CI will likely run 0 tests and still succeed. Either convert these tests to Unity Test Framework (EditMode/PlayMode) tests, or add an explicit step that runs the project's custom Tests.runTests() entrypoint and fails the build on assertion failures.
| - name: Run Tests | |
| uses: game-ci/unity-test-runner@v4 | |
| env: | |
| UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }} | |
| UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }} | |
| UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} | |
| with: | |
| unityVersion: 2022.3.7f1 | |
| githubToken: ${{ secrets.GITHUB_TOKEN }} | |
| checkName: Unity Test Results | |
| - name: Run Custom Unity Tests | |
| uses: game-ci/unity-builder@v4 | |
| env: | |
| UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }} | |
| UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }} | |
| UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} | |
| with: | |
| unityVersion: 2022.3.7f1 | |
| targetPlatform: StandaloneLinux64 | |
| customParameters: -batchmode -nographics -quit -executeMethod Tests.runTests |
|
@copilot address comments; also there are compiler errors when opening the project with Unity 6.3 LTS: |
|
@dmccoystephenson I've opened a new pull request, #206, to work on those changes. Once the pull request is ready, I'll request review from you. |
…test runner Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…n ProjectSettings Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Fix EntityId ambiguity, replace CI test runner, restore Legacy Input Manager, and upgrade to Unity 6
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 290 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces a new Unity CI workflow and reorganizes several Unity
.metafiles to follow standard Unity project structure. The main changes are the addition of automated CI checks for Unity projects and the renaming of.metafiles to match their new locations within theAssetsdirectory.CI/CD Automation:
.github/workflows/unity-ci.ymlto automate checks for missing/orphaned.metafiles, run Unity tests, and build the project for Linux using GitHub Actions. This includes caching and artifact upload for test and build results.Project Structure Updates:
project-settings.metatoAssets/Prefabs.metato align with Unity folder conventions.src/c#/main.metatoAssets/Scenes.metafor proper scene asset management.src.metatoAssets/Scripts.meta, organizing scripts under the UnityAssetsfolder.src/c#.metatoAssets/Scripts/Tests.metato place test scripts in the correct Unity subdirectory.